Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate lint option in the join command #1349

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

IgorKarpiuk
Copy link
Contributor

@IgorKarpiuk IgorKarpiuk commented Dec 7, 2023

What/Why/How?

Add deprecate warning for the --lint option in the join command.

Reference

Related: #1250

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Dec 7, 2023

🦋 Changeset detected

Latest commit: 9fd0876

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.054 ± 0.036 1.020 1.136 1.01 ± 0.04
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.040 ± 0.014 1.021 1.059 1.00

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.15% 4073/5349
🟡 Branches 66.04% 2168/3283
🟡 Functions 68.32% 660/966
🟡 Lines 76.34% 3820/5004
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡 cli/src/utils.ts 64.88% 51.85%
75.47% (-1.45% 🔻)
64.29%
🟢
... / bundle.ts
87.69% 68.89% 100% 87.69%

Test suite run success

652 tests passing in 94 suites.

Report generated by 🧪jest coverage report action from 9fd0876

@IgorKarpiuk IgorKarpiuk force-pushed the chore/deprecate-lint-in-join branch from a7b6ed1 to 9ad4e6e Compare December 7, 2023 16:36
@IgorKarpiuk IgorKarpiuk self-assigned this Dec 8, 2023
@IgorKarpiuk IgorKarpiuk marked this pull request as ready for review December 8, 2023 08:15
@IgorKarpiuk IgorKarpiuk requested a review from a team as a code owner December 8, 2023 08:15
@IgorKarpiuk IgorKarpiuk requested a review from lornajane December 8, 2023 08:33
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor copy/paste error spotted, but otherwise looks good!

docs/commands/join.md Outdated Show resolved Hide resolved
@IgorKarpiuk IgorKarpiuk force-pushed the chore/deprecate-lint-in-join branch from b540d72 to 9fd0876 Compare December 14, 2023 16:00
@IgorKarpiuk IgorKarpiuk merged commit 588b956 into main Dec 14, 2023
30 checks passed
@IgorKarpiuk IgorKarpiuk deleted the chore/deprecate-lint-in-join branch December 14, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants