chore: removed 'no-actions-type-end' rule (#1826)

Redocly · Dec 17, 2024 · 4523355 · 4523355 · github-actions · Dec 17, 2024
1 parent 05cb768
commit 4523355
Show file tree

Hide file tree

Showing 14 changed files with 5 additions and 215 deletions.
diff --git a/.changeset/new-falcons-unite.md b/.changeset/new-falcons-unite.md
@@ -0,0 +1,5 @@
+---
+"@redocly/openapi-core": patch
+---
+
+Removed the `no-actions-type-end` Spot rule.
diff --git a/docs/guides/lint-arazzo.md b/docs/guides/lint-arazzo.md
@@ -85,7 +85,6 @@ The rules available for linting Arazzo are:
 - `step-onFailure-unique`: the `onFailure` actions of the `step` object must be unique.
 - `requestBody-replacements-unique`: the `replacements` of the `requestBody` object must be unique.
 - `no-criteria-xpath`: the `xpath` type criteria is not supported by Spot.
-- `no-actions-type-end`: the `end` type action is not supported by Spot.
 - `criteria-unique`: the criteria list must not contain duplicated assertions.
 
 Add the rules to `redocly.yaml`, but for Arazzo specifications, the rules go in their own configuration section called `arazzoRules`.

diff --git a/docs/rules/spec-ruleset.md b/docs/rules/spec-ruleset.md
@@ -22,5 +22,4 @@ All the rules are of severity `error`:
 - `step-onFailure-unique`
 - `requestBody-replacements-unique`
 - `no-criteria-xpath`
-- `no-actions-type-end`
 - `criteria-unique`
diff --git a/docs/rules/spot/no-actions-type-end.test.md b/docs/rules/spot/no-actions-type-end.test.md
diff --git a/packages/core/src/config/__tests__/__snapshots__/config-resolvers.test.ts.snap b/packages/core/src/config/__tests__/__snapshots__/config-resolvers.test.ts.snap
@@ -6,7 +6,6 @@ exports[`resolveConfig should ignore minimal from the root and read local file 1
   "arazzo1Preprocessors": {},
   "arazzo1Rules": {
     "criteria-unique": "warn",
-    "no-actions-type-end": "warn",
     "no-criteria-xpath": "warn",
     "parameters-not-in-body": "warn",
     "parameters-unique": "error",
@@ -234,7 +233,6 @@ exports[`resolveStyleguideConfig should resolve extends with local file config w
   "arazzo1Preprocessors": {},
   "arazzo1Rules": {
     "criteria-unique": "warn",
-    "no-actions-type-end": "warn",
     "no-criteria-xpath": "warn",
     "parameters-not-in-body": "warn",
     "parameters-unique": "error",

diff --git a/packages/core/src/config/all.ts b/packages/core/src/config/all.ts
@@ -211,7 +211,6 @@ const all: PluginStyleguideConfig<'built-in'> = {
   arazzo1Rules: {
     'criteria-unique': 'error',
     'no-criteria-xpath': 'error',
-    'no-actions-type-end': 'error',
     'parameters-not-in-body': 'error',
     'parameters-unique': 'error',
     'requestBody-replacements-unique': 'error',

diff --git a/packages/core/src/config/minimal.ts b/packages/core/src/config/minimal.ts
@@ -187,7 +187,6 @@ const minimal: PluginStyleguideConfig<'built-in'> = {
   arazzo1Rules: {
     'criteria-unique': 'off',
     'no-criteria-xpath': 'off',
-    'no-actions-type-end': 'off',
     'parameters-not-in-body': 'off',
     'parameters-unique': 'off',
     'requestBody-replacements-unique': 'off',

diff --git a/packages/core/src/config/recommended-strict.ts b/packages/core/src/config/recommended-strict.ts
@@ -187,7 +187,6 @@ const recommendedStrict: PluginStyleguideConfig<'built-in'> = {
   arazzo1Rules: {
     'criteria-unique': 'error',
     'no-criteria-xpath': 'error',
-    'no-actions-type-end': 'error',
     'parameters-not-in-body': 'error',
     'parameters-unique': 'error',
     'requestBody-replacements-unique': 'error',

diff --git a/packages/core/src/config/recommended.ts b/packages/core/src/config/recommended.ts
@@ -187,7 +187,6 @@ const recommended: PluginStyleguideConfig<'built-in'> = {
   arazzo1Rules: {
     'criteria-unique': 'warn',
     'no-criteria-xpath': 'warn',
-    'no-actions-type-end': 'warn',
     'parameters-not-in-body': 'warn',
     'parameters-unique': 'error',
     'requestBody-replacements-unique': 'warn',

diff --git a/packages/core/src/config/spec.ts b/packages/core/src/config/spec.ts
@@ -24,7 +24,6 @@ const spec: PluginStyleguideConfig<'built-in'> = {
     'step-onFailure-unique': 'error',
     'requestBody-replacements-unique': 'error',
     'no-criteria-xpath': 'error',
-    'no-actions-type-end': 'error',
     'criteria-unique': 'error',
   },
 };

diff --git a/packages/core/src/rules/arazzo/__tests__/no-actions-type-end.test.ts b/packages/core/src/rules/arazzo/__tests__/no-actions-type-end.test.ts
diff --git a/packages/core/src/rules/arazzo/index.ts b/packages/core/src/rules/arazzo/index.ts
@@ -13,7 +13,6 @@ import { StepOnSuccessUnique } from './step-onSuccess-unique';
 import { StepOnFailureUnique } from './step-onFailure-unique';
 import { RequestBodyReplacementsUnique } from './requestBody-replacements-unique';
 import { NoCriteriaXpath } from '../spot/no-criteria-xpath';
-import { NoActionsTypeEnd } from '../spot/no-actions-type-end';
 import { CriteriaUnique } from './criteria-unique';
 
 import type { Arazzo1Rule } from '../../visitors';
@@ -35,7 +34,6 @@ export const rules: Arazzo1RuleSet<'built-in'> = {
   'step-onFailure-unique': StepOnFailureUnique,
   'requestBody-replacements-unique': RequestBodyReplacementsUnique,
   'no-criteria-xpath': NoCriteriaXpath,
-  'no-actions-type-end': NoActionsTypeEnd,
   'criteria-unique': CriteriaUnique,
 };
 

diff --git a/packages/core/src/rules/spot/no-actions-type-end.ts b/packages/core/src/rules/spot/no-actions-type-end.ts
diff --git a/packages/core/src/types/redocly-yaml.ts b/packages/core/src/types/redocly-yaml.ts
@@ -154,7 +154,6 @@ const builtInArazzo1Rules = [
   'step-onFailure-unique',
   'requestBody-replacements-unique',
   'no-criteria-xpath',
-  'no-actions-type-end',
   'criteria-unique',
 ] as const;
St.^❔	Category	Percentage	Covered / Total
🟡	Statements	78.64%	5047/6418
🟡	Branches	67.27%	2053/3052
🟡	Functions	73.16%	834/1140
🟡	Lines	78.93%	4760/6031