Actually drop mongodb #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnpmitsch
force-pushed
the
debug_event_listener
branch
3 times, most recently
from
ce2e35e to
232ca07
Compare
johnpmitsch
force-pushed
the
debug_event_listener
branch
from
232ca07 to
857e14b
Compare
|
yee-haw |
johnpmitsch
force-pushed
the
debug_event_listener
branch
2 times, most recently
from
c7b59a0 to
bf3eff7
Compare
|
yee-haw |
bbuckingham
reviewed
Nov 30, 2017
| @@ -1,5 +1,5 @@ | |||
| - name: Drop old mongo database | |||
| command: echo 'db.dropDatabase();' | mongo pulp_database | |||
| command: mongo pulp_database --eval "db.dropDatabase()" | |||
There was a problem hiding this comment.
I see a similar call in satellite-clone/tasks/reset_pulp_data.yml, should it also be updated?
There was a problem hiding this comment.
Thanks brad, I updated that line as well, its possible that that wasn't executing properly as well so good catch.
Since that runs only on backups w/o pulp_data I'll add that scenario to jenkins and re-run.
johnpmitsch
force-pushed
the
debug_event_listener
branch
from
bf3eff7 to
827ef1e
Compare
johnpmitsch
force-pushed
the
debug_event_listener
branch
2 times, most recently
from
1fe5c98 to
21e8a6f
Compare
The echo command we were using wasn't actually dropping the mongo database, but rather echoing 'db.dropDatabase();' | mongo pulp_database This resulted in data being restored on an existing database. So the mongo database stayed during restore. We didn't notice many issues because not much is in the mongo database on a clean satellite install. Fixes RedHatSatellite#259
johnpmitsch
force-pushed
the
debug_event_listener
branch
from
21e8a6f to
a3d319b
Compare
|
currently jenkins is blocked by #275 |
|
yee-haw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The echo command we were using wasn't actually dropping the mongo
database, but rather echoing 'db.dropDatabase();' | mongo pulp_database
This resulted in data being restored on an existing database.
So the mongo database stayed during restore. We didn't notice many issues
because not much is in the mongo database on a clean satellite install.
Fixes #259