Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patternfly v4 to v5 migration #124

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Patternfly v4 to v5 migration #124

merged 4 commits into from
Oct 25, 2023

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Oct 18, 2023 •
edited
Loading

Please ignore the failing PR check, fails are most likely unrelated to the PR.

Make sure to run the app with npm run start.

@leSamo leSamo requested a review from a team as a code owner October 18, 2023 19:01
@leSamo leSamo marked this pull request as draft October 18, 2023 19:01
@leSamo leSamo marked this pull request as ready for review October 23, 2023 22:20
AsToNlele
AsToNlele approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 😄 LGTM

Only changes I've found from the v4 version are a gap between the filter name and the down arrow and the missing blue line on the left when you expand a CVE, but maybe this included of the new version or a different prop.

This PR Stage
image image

@leSamo
Copy link
Member Author

leSamo commented Oct 25, 2023

@AsToNlele Nice catch, I looked at the Patternfly documentation and this is actually intentional.

@leSamo leSamo merged commit ca15010 into master Oct 25, 2023
3 checks passed
@leSamo leSamo mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsToNlele AsToNlele AsToNlele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leSamo @AsToNlele