[RHCLOUD-36102] - Slow loading of data from roles endpoint perfo… #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanCasey13
changed the title
astrozzc
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Based on the extra query you got from django silk, this seems to be n+1 query issue.
I think you can improve the performance by using prefetch related in the get_role_queryset method. We just need to include the permission lookup and external relation lookup there as well.
…ynamically when passed in add_fields query param
astrozzc
reviewed
Dec 12, 2024
|
/retest |
1 similar comment
|
/retest |
astrozzc
approved these changes
Jan 14, 2025
rbac/management/role/view.py
Outdated
| @@ -141,6 +142,7 @@ class RoleViewSet( | |||
| filterset_class = RoleFilter | |||
| ordering_fields = ("name", "display_name", "modified", "policyCount") | |||
| ordering = ("name",) | |||
| default_limit = StandardResultsSetPagination.default_limit | |||
There was a problem hiding this comment.
Nope thats redundant removed now, was from my testing of filtering and pagination stuff
astrozzc
approved these changes
Jan 14, 2025
petracihalova
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rmance fixes
Link(s) to Jira
https://issues.redhat.com/browse/RHCLOUD-36102
Description of Intent of Change(s)
Originally focused on fine grained handling of filtering and pagination, this did not lead to any significant reduction in number of queries or performance improvements.
Using prefetch_related for "access", "ext_relation" and "access__permission" reduced the number of queries from 33 to 6 for a request to the roles endpoint for the get_role_queryset method.
Local Testing
How can the feature be exercised?
How can the bug be exploited and fix confirmed?
Is any special local setup required?
Checklist
Secure Coding Practices Checklist Link
Secure Coding Practices Checklist