-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Tailorings): RHINENG-14520 - Fix export for wizard #2314
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2314 +/- ##
=======================================
Coverage 68.07% 68.07%
=======================================
Files 357 357
Lines 6471 6472 +1
Branches 2078 2078
=======================================
+ Hits 4405 4406 +1
Misses 2066 2066
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify the export has been downloaded and the items inside equal the rules in the table
I had 74 rules selected in the beginning and tried to show all of the available rules (not only the selected ones), and did the export as CSV. The end result contained only those that are selected which goes slightly against the expected results (to export all the items in the table). I have tried to select one more item (having 75 rules selected in total), but the exported CSV again contained only 74 initial rules.
@@ -42,6 +42,7 @@ const withExport = ({ | |||
downloadItems(exportColumns, items, format); | |||
onComplete?.(items); | |||
} catch (error) { | |||
console.log(error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log(error); | |
console.error(error); |
Adding filters (like Name) also doesn't change the exported data. |
This fixes the export for the Rules step in the "Create Policy" wizard.
How to test:
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist