Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(OpenAPI): RHINENG-15551 revert changes and manually update OpenAPI spec #2362

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix(OpenAPI): RHINENG-15551 revert changes and manually update OpenAPI spec #2362

merged 2 commits into from
Jan 24, 2025

Conversation

romanblanco
Copy link
Member

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@romanblanco
revert(OpenAPI): RHINENG-15551 specify what counts as a failed rule
e8192e3 
                 revert and update manually changes from 0db2214,
                 because it added extra mime_type where it shouldn't be due to a hack from
                 d7d0fb5 that stopped working after upgrading to
                 Rails 8 in 8b53099.
@romanblanco
docs(APIv2): RHINENG-15551 specify what counts as a failed rule
57c2409 
             manually updated changes in openapi.json reverted in previous commit
@romanblanco romanblanco requested a review from a team as a code owner January 23, 2025 21:05
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (0db2214) to head (57c2409).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2362   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         200      200           
  Lines        4454     4454           
=======================================
  Hits         4376     4376           
  Misses         78       78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanblanco romanblanco changed the title rever(OpenAPI): RHINENG-15551 revert changes and manually update OpenAPI spec fix(OpenAPI): RHINENG-15551 revert changes and manually update OpenAPI spec Jan 24, 2025
RoamingNoMaD
RoamingNoMaD approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@RoamingNoMaD RoamingNoMaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RoamingNoMaD RoamingNoMaD merged commit d18f4c1 into RedHatInsights:master Jan 24, 2025
13 checks passed
@romanblanco romanblanco deleted the RHINENG-15551-revert-and-update-manually branch January 24, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoamingNoMaD RoamingNoMaD RoamingNoMaD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanblanco @RoamingNoMaD