Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OpenAPI): RHINENG-15164 specify what counts as a failed rule #2359

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

RoamingNoMaD
Copy link
Contributor

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@RoamingNoMaD RoamingNoMaD requested a review from a team as a code owner January 21, 2025 16:11
@RoamingNoMaD RoamingNoMaD changed the title fix(OpenAPI): specify what counts as a failed rule fix(OpenAPI): RHINENG-15164 specify what counts as a failed rule Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (89e5a59) to head (70a5fda).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2359   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         200      200           
  Lines        4454     4454           
=======================================
  Hits         4376     4376           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be done here first:

description: 'Number of failed rules in the Test Result'

After, you can generate the openapi.json by running

podman-compose exec rails bundle exec rake rswag:specs:swaggerize

(see https://github.com/RedHatInsights/compliance-backend?tab=readme-ov-file#api-documentation)

@RoamingNoMaD RoamingNoMaD force-pushed the fix-spec-wording branch 2 times, most recently from 953c861 to ad5e50d Compare January 22, 2025 13:36
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@romanblanco romanblanco enabled auto-merge (rebase) January 22, 2025 15:23
@romanblanco romanblanco merged commit 0db2214 into RedHatInsights:master Jan 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants