refactor(Graphana): RHINENG-15507 replace kafka lag metric #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanblanco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2358 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 200 200
Lines 4454 4454
=======================================
Hits 4376 4376
Misses 78 78 ☔ View full report in Codecov by Sentry. |
RoamingNoMaD
force-pushed
the
prometheus-kafka-metrics
branch
4 times, most recently
from
45a57fc to
39ff8ec
Compare
RoamingNoMaD
changed the title
|
/retest |
romanblanco
reviewed
Jan 28, 2025
| }, | ||
| "expr": "sum(kafka_consumergroup_group_topic_sum_lag{topic=~\".*platform.inventory.events\", group=\"complianceinventory-events-consumer\"}) by (topic)", | ||
| "editorMode": "code", | ||
| "expr": "sum by(topic) (aws_kafka_max_offset_lag_sum{consumer_group=\"complianceinventory-events-consumer\", topic=~\".*platform.inventory.events\"})", |
There was a problem hiding this comment.
According to the latest update, this should be changed to
Suggested change
| "expr": "sum by(topic) (aws_kafka_max_offset_lag_sum{consumer_group=\"complianceinventory-events-consumer\", topic=~\".*platform.inventory.events\"})", | |
| "expr": "sum by(topic) (aws_kafka_sum_offset_lag_sum{consumer_group=\"complianceinventory-events-consumer\", topic=~\".*platform.inventory.events\"})", |
romanblanco
requested changes
Jan 28, 2025
romanblanco
force-pushed
the
prometheus-kafka-metrics
branch
from
979d1c0 to
2a17246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist