Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed overflowing extension status button #540

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

shreya-mishra
Copy link
Contributor

Date: 8/12/2023

Developer Name: Shreya


Issue Ticket Number

Description

Fixed the overflowing extension status button

Screenshot

image

Documentation Updated?

  • Yes
  • No

If your feature adds a new API, then documentation related to the feature like API-Contracts, and Data-models must be updated.

Breaking Changes

  • Yes
  • No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.

Development Tested?

  • Yes
  • No

Confirm whether the changes have been tested locally during development.

Tested in Staging?

  • Yes
  • No

Indicate whether the changes have been tested in the staging environment.

Under Feature Flag

  • Yes
  • No

Specify if the changes are currently under a feature flag.

Database Changes

  • Yes
  • No

Indicate whether the changes include modifications to the database.

Screenshots

Attach any relevant screenshots, such as test coverage reports, before and after images, or other visual aids.

Test Coverage

Provide information on the test coverage for the changes made in this PR. Include details on the types of tests conducted and their outcomes.

Additional Notes

Include any additional notes, considerations, or explanations that might be helpful for reviewers.

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit 2ac8496
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/657320e0f15b080008f0905f
😎 Deploy Preview https://deploy-preview-540--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shreya-mishra shreya-mishra self-assigned this Dec 8, 2023
Copy link
Contributor

@lakshayman lakshayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line change (width: auto), rest are lint changes.
LGTM

@Ajeyakrishna-k
Copy link
Contributor

Can you share a working video for different device size?

@iamitprakash iamitprakash merged commit 55e9ce7 into develop Dec 8, 2023
5 checks passed
@iamitprakash iamitprakash deleted the fix/extensionStatusButton branch December 8, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants