Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure tests use staging API to prevent production impact #911

Merged
merged 6 commits into from
Nov 30, 2024
Merged

fix: ensure tests use staging API to prevent production impact #911

merged 6 commits into from
Nov 30, 2024

Conversation

AnujChhikara
Copy link
Member

@AnujChhikara AnujChhikara commented Nov 13, 2024 •
edited
Loading

Date: 13 Nov 2024

Developer Name: @AnujChhikara

Issue Ticket Number

Description

This PR updates the application's test configuration to ensure that all test API requests are directed to the staging environment instead of the production API. This change prevents potential impacts on production behavior during testing.

Changes

  • Updated API base URL in the test environment to use the staging endpoint.
  • Modified the loadENV configuration to ensure that the application defaults to the staging API when running on localhost, aligning both local development and test environments with the staging setup.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

Screenshot 1

Additional Notes

@AnujChhikara AnujChhikara marked this pull request as ready for review November 19, 2024 06:06
@prakashchoudhary07
Copy link
Contributor

Please resolve merge conflicts

pankajjs
pankajjs reviewed Nov 27, 2024
View reviewed changes
mock-data/constants.js Outdated Show resolved Hide resolved
VinuB-Dev
VinuB-Dev reviewed Nov 27, 2024
View reviewed changes
helpers/loadENV.js Outdated Show resolved Hide resolved
VinuB-Dev
VinuB-Dev approved these changes Nov 28, 2024
View reviewed changes
Copy link

@VinuB-Dev VinuB-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamitprakash iamitprakash merged commit 2b39df5 into Real-Dev-Squad:develop Nov 30, 2024
4 checks passed
@Achintya-Chatterjee Achintya-Chatterjee mentioned this pull request Dec 2, 2024
Merged
10 tasks
@AnujChhikara AnujChhikara deleted the fix-tests-calling-prodAPI branch December 4, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakashchoudhary07 prakashchoudhary07 prakashchoudhary07 left review comments

@pankajjs pankajjs pankajjs approved these changes

@VinuB-Dev VinuB-Dev VinuB-Dev approved these changes

@iamitprakash iamitprakash iamitprakash approved these changes

Assignees

@AnujChhikara AnujChhikara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests Calling Production API Instead of Staging API
5 participants
@AnujChhikara @prakashchoudhary07 @iamitprakash @VinuB-Dev @pankajjs