Dev to Main Sync #903
Merged
Dev to Main Sync #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed (#900) * Fix: Side panel data not updating when different user cards are clicked * renamed the variable * added tests * using staging api url for testing
…o super_user only (#896) * Restrict approve and reject buttons on the Task Request detail page to super users only * fixes naming convention, button render logic * fix: reject button should not be part of the dom if condition not met * changed the superUser data, make the task-request/script.js type module * added tests how buttons should render for non-super user * Update task-requestDetails.test.js removed unused variable * using data-testid for the tests * importing the superuser data * removing reject button from dom after successful task update * put the changes behind the feature flag --------- Co-authored-by: Achintya Chatterjee <[email protected]>
pankajjs
reviewed
Nov 1, 2024
| expect(rejectButton).toBeNull(); | ||
| }); | ||
|
|
||
| it('Should render task status for non-super users', async function () { |
* task-requestDetails test fix * removed fixed delays
Deploying dashboard-rds with
|
| Latest commit: |
d1641bd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://027cad21.dashboard-rds.pages.dev |
| Branch Preview URL: | https://develop.dashboard-rds.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 1 Nov 2024
Developer Name: Anuj Chhikara, Prashant Kumar ,
Issue Ticket Number
PR's going in this sync
Screenshots
PR 900
PR 896
-Button Working
Untitled.Video.November.1.2024.1_03.PM.mp4