Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/repository links for webpages #863

Merged
merged 35 commits into from
Oct 16, 2024
Merged

Feature/repository links for webpages #863

merged 35 commits into from
Oct 16, 2024

Conversation

shantanu-02
Copy link
Contributor

@shantanu-02 shantanu-02 commented Sep 29, 2024 •
edited by Achintya-Chatterjee
Loading

Date: 29/09/2024
Developer Name: shantanu-pawar-1

Issue Ticket Number

Description

On the Dashboard site of RDS, where links to various web pages are present at the bottom of each web page add the repository link of respective web page.

  • Change 1: Added footer containing repository link for Discord Users web page.
  • Change 2: Added footer containing repository link for Discord Groups web page.
  • Change 3: Added footer containing repository link for Applications web page.

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot (112)
Screenshot (113)
Screenshot (114)
Screenshot (115)
Screenshot (116)

nimrit-singh
nimrit-singh reviewed Sep 30, 2024
View reviewed changes
Copy link

@nimrit-singh nimrit-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed 01-10-2024

nimrit-singh
nimrit-singh approved these changes Sep 30, 2024
View reviewed changes
Copy link

@nimrit-singh nimrit-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

vinit717
vinit717 requested changes Sep 30, 2024
View reviewed changes
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the test and why there is both package lock and yarn lock ?

package.json Outdated Show resolved Hide resolved
@shantanu-02 shantanu-02 force-pushed the feature/repository-links-for-webpages branch from 61a4b64 to 2c52438 Compare September 30, 2024 19:11
vinit717
vinit717 reviewed Sep 30, 2024
View reviewed changes
footerTest.js Outdated Show resolved Hide resolved
@vinit717
Copy link
Member

vinit717 commented Oct 2, 2024

The footer is not aligned at applications and discord group page

vinit717
vinit717 requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the build on CI

__tests__/applications/applications.test.js Outdated Show resolved Hide resolved
groups/style.css Outdated Show resolved Hide resolved
applications/style.css Outdated Show resolved Hide resolved
footerTest.js Outdated Show resolved Hide resolved
vinit717
vinit717 requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@vinit717 vinit717 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the footer to a different file/folder and import it at every other place where it is used? As you are repeating same HTML several times

__tests__/applications/applications.test.js Outdated Show resolved Hide resolved
applications/style.css Outdated Show resolved Hide resolved
@vinit717
Copy link
Member

o different and import at every other place where it is used

Can you add the footer to a different file/folder and import it at every other place where it is used? As you are repeating same HTML several times

@shantanu-02

vinit717
vinit717 requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my last review why there too much file changed?
also update the screen shot from the pr

@shantanu-02
Copy link
Contributor Author

After my last review why there too much file changed? also update the screen shot from the pr

Beacuse previously there were pages which had footer...but only 3 files didn't had any...so my task ws to add fotter to those pages only...That's why asked you before making reusable component...since I made the footer component I replaced that component with previously written footers

@shantanu-02
Copy link
Contributor Author

After my last review why there too much file changed? also update the screen shot from the pr

Done with the new screenshots.

@vinit717
Copy link
Member

After my last review why there too much file changed? also update the screen shot from the pr

Beacuse previously there were pages which had footer...but only 3 files didn't had any...so my task ws to add fotter to those pages only...That's why asked you before making reusable component...since I made the footer component I replaced that component with previously written footers

So for now update only the 3 files for rest of the file create another pr

@shantanu-02
Copy link
Contributor Author

After my last review why there too much file changed? also update the screen shot from the pr

Beacuse previously there were pages which had footer...but only 3 files didn't had any...so my task ws to add fotter to those pages only...That's why asked you before making reusable component...since I made the footer component I replaced that component with previously written footers

So for now update only the 3 files for rest of the file create another pr

Done with the changes please review.

vinit717
vinit717 reviewed Oct 12, 2024
View reviewed changes
applications/style.css Outdated Show resolved Hide resolved
groups/style.css Outdated Show resolved Hide resolved
vinit717
vinit717 reviewed Oct 15, 2024
View reviewed changes
footerTest.js Outdated Show resolved Hide resolved
@vinit717
Copy link
Member

Can you add more screenshots with different screen size also fix the failing test

vinit717
vinit717 reviewed Oct 16, 2024
View reviewed changes
__tests__/users/App.test.js Outdated Show resolved Hide resolved
__tests__/users/App.test.js Show resolved Hide resolved
@iamitprakash iamitprakash merged commit 7476581 into Real-Dev-Squad:develop Oct 16, 2024
4 checks passed
@shantanu-02 shantanu-02 mentioned this pull request Oct 17, 2024
Merged
VaibhavSingh8 pushed a commit that referenced this pull request Nov 4, 2024
@shantanu-02 @vinit717 @VaibhavSingh8
Feature/repository links for webpages (#863)
911f809 
* fix: Added footer contaning repo link for every webpage

* fix: Added footer contaning repo link for every webpage

* Enhancement: Added tests for new URLs

* Enhancement: Added tests for new URLs

* Fix: Removed Live URLs which do not have footer from testing

* Enhancement: Fixed position for footer

* fix: removed commented content

* Enhancement: Used adata-test-id instead of class/id

* Fix: footer position styling

* Fix: changes using data-test-id

* Fix: Prettier changes

* Fix: minor bug fixes

* Enhancement: Made reusable footer component

* Enhancement: Replaced footer of webpages with footer component

* Fix: Minor fixes

* Fix: Removed additional footers

* Fix: Removed additional footers

* Fix: Removed additional footers

* Fix: Added styles in global stylesheet

* Fix: Minor fix of stylesheet

* Fix: Test timeout error

* Fix: Using data-test-id instead of classes

---------

Co-authored-by: Vinit khandal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinit717 vinit717 vinit717 approved these changes

@nimrit-singh nimrit-singh nimrit-singh approved these changes

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee approved these changes

Assignees

@shantanu-02 shantanu-02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a repository link at the bottom of each webpage available on the dashboard site
5 participants
@shantanu-02 @vinit717 @Achintya-Chatterjee @nimrit-singh @iamitprakash