Resolves the Milliseconds Conversion #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyrandhir
changed the title
Deploying with
|
| Latest commit: |
8304cd1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fcc158db.dashboard-rds.pages.dev |
| Branch Preview URL: | https://fix-resolve-util-fn.dashboard-rds.pages.dev |
bhtibrewal
approved these changes
Nov 6, 2023
sahsisunny
approved these changes
Nov 6, 2023
heyrandhir
added a commit
that referenced
this pull request
Nov 6, 2023
* feature flag removal * Fix Task Request Details Page (#602) * fix oversize image, adds toasts and assignedTo * adds modal on click of avatar and name * test for modal * fix failing test * change cursor style to indicate clickable * fix failing test * fix the failing test condition * add safety check for taskrequest which dont have users info * resolve Sunny comment on the PR * resolve comments from Bhavika * fixes the event listener on the global window obj * fixes failing test * rename variable and remove commented code * Resolves the Milliseconds Conversion (#604) * removes the conversion to ms as it was already in ms * modifies the timestamp as per the current format in fixtures --------- Co-authored-by: meanwhile7 <[email protected]> Co-authored-by: Vishal kamat <[email protected]> Co-authored-by: Amit Prakash <[email protected]>
iamitprakash
added a commit
that referenced
this pull request
Nov 9, 2023
Dev to Main Sync (#605) * feature flag removal * Fix Task Request Details Page (#602) * fix oversize image, adds toasts and assignedTo * adds modal on click of avatar and name * test for modal * fix failing test * change cursor style to indicate clickable * fix failing test * fix the failing test condition * add safety check for taskrequest which dont have users info * resolve Sunny comment on the PR * resolve comments from Bhavika * fixes the event listener on the global window obj * fixes failing test * rename variable and remove commented code * Resolves the Milliseconds Conversion (#604) * removes the conversion to ms as it was already in ms * modifies the timestamp as per the current format in fixtures --------- Co-authored-by: Randhir Kumar Singh <[email protected]> Co-authored-by: meanwhile7 <[email protected]> Co-authored-by: Vishal kamat <[email protected]> Co-authored-by: Amit Prakash <[email protected]>
iamitprakash
added a commit
that referenced
this pull request
Nov 9, 2023
Dev to Main Sync (#605) * feature flag removal * Fix Task Request Details Page (#602) * fix oversize image, adds toasts and assignedTo * adds modal on click of avatar and name * test for modal * fix failing test * change cursor style to indicate clickable * fix failing test * fix the failing test condition * add safety check for taskrequest which dont have users info * resolve Sunny comment on the PR * resolve comments from Bhavika * fixes the event listener on the global window obj * fixes failing test * rename variable and remove commented code * Resolves the Milliseconds Conversion (#604) * removes the conversion to ms as it was already in ms * modifies the timestamp as per the current format in fixtures --------- Co-authored-by: Randhir Kumar Singh <[email protected]> Co-authored-by: meanwhile7 <[email protected]> Co-authored-by: Vishal kamat <[email protected]> Co-authored-by: Amit Prakash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ticket Number:-
Backend changes
Frontend Changes
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Deployment notes
None
Description
Eliminates the need for converting to milliseconds since the input was already in milliseconds.
Testing Stats: