Fix: Side panel data not updating when different user cards are clicked

Real-Dev-Squad · Oct 24, 2024 · 00a81d4 · 00a81d4
1 parent 0399dcd
commit 00a81d4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/users/discord/App.js b/users/discord/App.js
@@ -37,16 +37,16 @@ const handleTabNavigation = async (e) => {
   }
 };
 
-const handleUserSelected = (e) => {
-  const selectedUserId =
-    e.target?.getAttribute('data_key') ||
-    e.target.parentElement?.getAttribute('data_key');
-
-  if (selectedUserId) {
-    showUser = usersData[activeTab]?.findIndex(
-      (user) => user.id === selectedUserId,
+const handleUserSelected = (userId) => {
+  if (userId) {
+    const selectedIndex = usersData[activeTab]?.findIndex(
+      (user) => user.id === userId,
     );
-    rerender(App(), window['root']);
+
+    if (selectedIndex !== -1) {
+      showUser = selectedIndex;
+      rerender(App(), window['root']);
+    }
   }
 };
 

diff --git a/users/discord/components/UsersSection.js b/users/discord/components/UsersSection.js
@@ -5,7 +5,7 @@ export const UsersSection = ({ users, showUser, handleUserSelected }) => {
     'aside',
     {
       class: 'users_section',
-      onClick: handleUserSelected,
+
       'data-testid': 'users-section',
     },
     users?.map((user) => {
@@ -17,6 +17,7 @@ export const UsersSection = ({ users, showUser, handleUserSelected }) => {
           }`,
           'data-testid': `user-card-${user.id}`,
           'data-key': user.id,
+          onclick: () => handleUserSelected(user.id),
         },
         [
           createElement('img', {