fix: Add support to fetch onboarding extension request #2331
+92
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajjs
force-pushed
the
fix/get-request
branch
2 times, most recently
from
aade0fc to
a292d17
Compare
pankajjs
changed the title
pankajjs
changed the title
pankajjs
force-pushed
the
fix/get-request
branch
3 times, most recently
from
f5bb6a0 to
ac62e20
Compare
pankajjs
force-pushed
the
fix/get-request
branch
from
ac62e20 to
3eaed65
Compare
- Add requestedBy field in the fetch query - Add tests to verify the chanes
pankajjs
force-pushed
the
fix/get-request
branch
from
3eaed65 to
63e101b
Compare
vikasosmium
approved these changes
Jan 11, 2025
AnujChhikara
approved these changes
Jan 11, 2025
|
LGTM |
Achintya-Chatterjee
approved these changes
Jan 14, 2025
yesyash
pushed a commit
that referenced
this pull request
Jan 18, 2025
* fix: Add support to fetch onboarding extension by requestedBy field - Add requestedBy field in the fetch query - Add tests to verify the chanes * fix: Add changes under dev flag and fix failing tests * chore: fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 2 Jan, 2025
Developer Name: @pankajjs
Issue Ticket Number
Description
This PR fixes GET /request endpoint by introducing ONBOARDING type in validator and fetching onboarding extension requests by requestedBy field under enabled feature flag.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes