feat(interval): option to unref sleep interval #378
+15
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, this is not a problem, however when using
bufferCountOrTime()
in unit tests, Jest tends to hang due to the interval used insleep()
.Demo:
This PR adds an optional
unref: boolean
parameters that default to the current behaviour. I think it makes sense to unref only inbufferCountOrTime()
andtimeout()
.There are currently not really tests for any of the affected files. I would defer coverage of more operators for another PR, if that is okay.