Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage headers fix #163

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Homepage headers fix #163

wants to merge 3 commits into from

Conversation

jennethydyrova
Copy link
Collaborator

@louisrli I created mixin for headers to make code cleaner, since we were repeating this code in many files.

@jennethydyrova jennethydyrova added the Refactor A code change that neither fixes a bug nor adds a feature label Nov 22, 2020
@jennethydyrova jennethydyrova added this to the Bug Bash milestone Nov 22, 2020
@jennethydyrova jennethydyrova self-assigned this Nov 22, 2020
louisrli
louisrli reviewed Nov 22, 2020
View reviewed changes
Copy link
Contributor

@louisrli louisrli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ones a little big/risky for post code-freeze since it touches all components (similar to jamils desire to refactor all his components), if this is purely a code cleanup you can leave this PR open for after the graduation and submit it

@jennethydyrova
Copy link
Collaborator Author

jennethydyrova commented Nov 22, 2020 •
edited
Loading

yes, I didn't do anything except of creating main and secondary header mixins and including it to h2 and h6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisrli louisrli louisrli left review comments

@Jamil-Bailony Jamil-Bailony Jamil-Bailony approved these changes

@hiba-machfej hiba-machfej Awaiting requested review from hiba-machfej

@mohammad-jundi mohammad-jundi Awaiting requested review from mohammad-jundi

At least 2 approving reviews are required to merge this pull request.

Assignees

@jennethydyrova jennethydyrova

Labels
Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
Bug Bash
Development

Successfully merging this pull request may close these issues.
3 participants
@jennethydyrova @louisrli @Jamil-Bailony