Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalizing verbose messages in bmerge.R #6728

Merged
merged 13 commits into from
Jan 30, 2025
Merged

Normalizing verbose messages in bmerge.R #6728

merged 13 commits into from
Jan 30, 2025

Conversation

rikivillalba
Copy link
Contributor

Closes #6554

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (79aed53) to head (2c2c55e).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6728   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          79       79           
  Lines       14635    14635           
=======================================
  Hits        14434    14434           
  Misses        201      201

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Comparison Plot

Generated via commit 2c2c55e

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 31 seconds
Installing different package versions 8 minutes and 22 seconds
Running and plotting the test cases 2 minutes and 26 seconds

MichaelChirico
MichaelChirico reviewed Jan 17, 2025
View reviewed changes
R/bmerge.R Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Jan 17, 2025
View reviewed changes
R/bmerge.R Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Jan 17, 2025
View reviewed changes
R/bmerge.R Outdated Show resolved Hide resolved
@MichaelChirico MichaelChirico mentioned this pull request Jan 17, 2025
Open
MichaelChirico
MichaelChirico reviewed Jan 22, 2025
View reviewed changes
R/bmerge.R Outdated Show resolved Hide resolved
@MichaelChirico
Copy link
Member

Looks like we still need to update some test outputs, o/w LGTM

@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Jan 24, 2025
@MichaelChirico
Copy link
Member

Strange, useFancyQuotes seems to have a much bigger implication for Windows. Not investigating for now.

@MichaelChirico
Copy link
Member

Strange, possibly this is an r-devel issue then?

@MichaelChirico
Copy link
Member

Merging; the error appears unrelated (#6771).

@MichaelChirico MichaelChirico merged commit b739ab2 into master Jan 30, 2025
7 of 9 checks passed
@MichaelChirico MichaelChirico deleted the bmerge_verbose_coerce_col branch January 30, 2025 03:17
@MichaelChirico MichaelChirico mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalizing verbose messages in bmerge.R
2 participants
@rikivillalba @MichaelChirico