Allow setDT(get(...)) to work as previously #6726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
commented
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6726 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 79 79
Lines 14625 14630 +5
=======================================
+ Hits 14424 14429 +5
Misses 201 201 ☔ View full report in Codecov by Sentry. |
|
lgtm |
tdhock
approved these changes
Jan 17, 2025
rffontenelle
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Allow setDT(get(...)) to work as previously * Quirks of test.data.table... * need to eval() in the right place * imitate the approach in other branches more closely * maybe we just needed enclos=? * Comment for posterity * Actually do the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6725
Eh, pretty hacky, I'm still not sure we've made a good solution of the breaking changes induced by #6551.
Anyway I think the change is good: running
setDT(env$x)should definitely behave the same assetDT(get('x', env)).