Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a devcontainer on alpine #6710

Merged
merged 10 commits into from
Jan 7, 2025
Merged

Add a devcontainer on alpine #6710

merged 10 commits into from
Jan 7, 2025

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Jan 6, 2025

This is for #6350.

After the investigation, I am OK kicking the can on this one a bit further. I wanted to investigate since on first glance, forder() being length-0 looked more concerning. But in actuality, it just means "input is sorted", which is the same as base::order() finds, hence not show-stopping -- this is pretty deeply edge-case behavior anyway.

I don't know enough about how forder() handles strings (especially w.r.t. encoding); AFAICT this will be a lot easier to debug after #6669 (since we can then use print-debugging to see how different parts of the routine give different results on different platforms).

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (70c64ac) to head (8c20925).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6710   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          79       79           
  Lines       14553    14553           
=======================================
  Hits        14352    14352           
  Misses        201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ben-schwen ben-schwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelChirico MichaelChirico merged commit ebbf128 into master Jan 7, 2025
10 checks passed
@MichaelChirico MichaelChirico deleted the alpine-devcontainer branch January 7, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants