-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a devcontainer on alpine #6710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6710 +/- ##
=======================================
Coverage 98.61% 98.61%
=======================================
Files 79 79
Lines 14553 14553
=======================================
Hits 14352 14352
Misses 201 201 ☔ View full report in Codecov by Sentry. |
ben-schwen
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #6350.
After the investigation, I am OK kicking the can on this one a bit further. I wanted to investigate since on first glance,
forder()
being length-0 looked more concerning. But in actuality, it just means "input is sorted", which is the same asbase::order()
finds, hence not show-stopping -- this is pretty deeply edge-case behavior anyway.I don't know enough about how
forder()
handles strings (especially w.r.t. encoding); AFAICT this will be a lot easier to debug after #6669 (since we can then use print-debugging to see how different parts of the routine give different results on different platforms).