Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain with=FALSE in j=lit:var cases #6700

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Jan 2, 2025

For #6671 (not closing because we should wait for the revdep checker to confirm the fix).

This also fixes a mistake where is.name(e[[1]]) was used. e[[1]] is always : in this case, and therefore is always a name. e[[2]] and e[[3]] are the arguments to :, which is what we really want to inspect.

The added tests help cover the mistaken logic there too.

@MichaelChirico MichaelChirico added this to the 1.17.0 milestone Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.61%. Comparing base (70c64ac) to head (dfde60a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6700   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          79       79           
  Lines       14553    14553           
=======================================
  Hits        14352    14352           
  Misses        201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2025

Comparison Plot

Generated via commit dfde60a

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 41 seconds
Installing different package versions 7 minutes and 38 seconds
Running and plotting the test cases 2 minutes and 15 seconds

@tdhock
Copy link
Member

tdhock commented Jan 6, 2025

lgtm thanks

@MichaelChirico MichaelChirico merged commit b150ab5 into master Jan 6, 2025
11 checks passed
@MichaelChirico MichaelChirico deleted the with-false-num-var branch January 6, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants