Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user-facing references to .internal.selfref #6698

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MichaelChirico
Copy link
Member

Closes #4519. Supersedes #6696.

Usage in internal errors is retained:

if (!isNull(p)) internal_error(__func__, ".internal.selfref ptr is neither NULL nor R_NilValue"); // # nocov

if (!(isNull(tag) || isString(tag))) internal_error(__func__, ".internal.selfref tag is neither NULL nor a character vector"); // # nocov

cc @aitap and @spiddy1204

Copy link

github-actions bot commented Jan 1, 2025

Comparison Plot

Generated via commit 8e4783d

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 27 seconds
Installing different package versions 8 minutes and 5 seconds
Running and plotting the test cases 2 minutes and 31 seconds

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (70c64ac) to head (8e4783d).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6698   +/-   ##
=======================================
  Coverage   98.61%   98.62%           
=======================================
  Files          79       79           
  Lines       14553    14630   +77     
=======================================
+ Hits        14352    14429   +77     
  Misses        201      201           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/data.table.R Outdated Show resolved Hide resolved
src/assign.c Outdated Show resolved Hide resolved
R/data.table.R Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need a reference page for .internal.selfref
3 participants