Fixing instructions state when set to an empty string #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiswells97
temporarily deployed
to
previews/1191/merge
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/1191/merge
GitHub Actions
Inactive
Merged
danhalson
added a commit
that referenced
this pull request
Feb 6, 2025
## What's Changed * Support output tabs in pyodide by @loiswells97 in #1157 * Downloading the instructions by @loiswells97 in #1160 * Hack open function to write files in main thread by @loiswells97 in #1146 * Try pinning previous ubuntu version to avoid cloudflare issue by @danhalson in #1178 * Integration: Save / Login functionality not as expected by @create-issue-branch in #1162 * HTML audio video support by @loiswells97 in #1179 * Feat/editable instructions by @loiswells97 in #1166 * Add remove instructions button modal by @jamiebenstead in #1176 * fix dark mode colours by @conorriches in #1182 * Copy change: Project steps to Project instructions by @loiswells97 in #1183 * Fixing padding for first line of code block by @loiswells97 in #1184 * Fix contrast on dark mode instructions code block by @loiswells97 in #1187 * Markdown changes by @jamiebenstead in #1188 * Remove line from demoInstructions by @jamiebenstead in #1189 * Instructions syntax highlighting for CEfE by @loiswells97 in #1190 * Fixing instructions state when set to an empty string by @loiswells97 in #1191 * Identify caching issue for editor-ui by @create-issue-branch in #1186 ## New Contributors * @jamiebenstead made their first contribution in #1176 **Full Changelog**: v0.28.14...v0.29.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a bug where the user deletes everything in the instructions box and it suddenly switches back to the empty instructions state. This was caused by the fact that an empty string is
falsyin Javascript, so when the instructions content was deleted we would getprojectInstructions = ""which resulted in the instructions being deleted.