Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cached instructions #1169

Merged
merged 10 commits into from
Jan 23, 2025
Merged

Fix cached instructions #1169

merged 10 commits into from
Jan 23, 2025

Conversation

loiswells97
Copy link
Contributor

@loiswells97 loiswells97 commented Jan 20, 2025 •
edited
Loading

@loiswells97 loiswells97 temporarily deployed to previews/1169/merge January 20, 2025 09:20 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/1169/merge January 20, 2025 09:41 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/1169/merge January 20, 2025 12:01 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/1169/merge January 20, 2025 12:10 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/1169/merge January 20, 2025 12:10 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/1169/merge January 20, 2025 12:37 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/1169/merge January 20, 2025 16:13 — with GitHub Actions Inactive
danhalson
danhalson approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@danhalson danhalson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, might just need to be careful that there wasn't any unintentional reliance on the state bleeding between mounts, pretty sure there isn't since I've looked into this logic too, but just worth keeping an eye on it

@loiswells97 loiswells97 merged commit 5a2cdf2 into feat/editable-instructions Jan 23, 2025
8 checks passed
@loiswells97 loiswells97 deleted the fix-cached-instructions branch January 23, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhalson danhalson danhalson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loiswells97 @danhalson