-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/editable instructions #1166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* unblocks us * merging into feature branch
* Autosaves instructions * also renders markdown instructions
 --------- Co-authored-by: Lois Wells <[email protected]>
…r-ui into feat/editable-instructions
conorriches
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all code to this point has had a PR and reviews, having taking a final skim through this looks good to me
Merged
danhalson
added a commit
that referenced
this pull request
Feb 6, 2025
## What's Changed * Support output tabs in pyodide by @loiswells97 in #1157 * Downloading the instructions by @loiswells97 in #1160 * Hack open function to write files in main thread by @loiswells97 in #1146 * Try pinning previous ubuntu version to avoid cloudflare issue by @danhalson in #1178 * Integration: Save / Login functionality not as expected by @create-issue-branch in #1162 * HTML audio video support by @loiswells97 in #1179 * Feat/editable instructions by @loiswells97 in #1166 * Add remove instructions button modal by @jamiebenstead in #1176 * fix dark mode colours by @conorriches in #1182 * Copy change: Project steps to Project instructions by @loiswells97 in #1183 * Fixing padding for first line of code block by @loiswells97 in #1184 * Fix contrast on dark mode instructions code block by @loiswells97 in #1187 * Markdown changes by @jamiebenstead in #1188 * Remove line from demoInstructions by @jamiebenstead in #1189 * Instructions syntax highlighting for CEfE by @loiswells97 in #1190 * Fixing instructions state when set to an empty string by @loiswells97 in #1191 * Identify caching issue for editor-ui by @create-issue-branch in #1186 ## New Contributors * @jamiebenstead made their first contribution in #1176 **Full Changelog**: v0.28.14...v0.29.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.