Integration: Save / Login functionality not as expected #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
conorriches
reviewed
Jan 28, 2025
| @@ -42,17 +42,26 @@ export const useProjectPersistence = ({ | |||
| const accessToken = user?.access_token; | |||
| const params = { reactAppApiEndpoint, accessToken }; | |||
|
|
|||
| if (saveTriggered) { | |||
| if (saveTriggered || localStorage.getItem("awaitingSave")) { | |||
There was a problem hiding this comment.
This looks great, where is awaitingSave set?
There was a problem hiding this comment.
it's set in standalone, when the login to save button is clicked - there's an incoming PR for that
There was a problem hiding this comment.
ah roger! I shall press the happy green button of joy!
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
danhalson
had a problem deploying
to
previews/1162/merge
GitHub Actions
Failure
Test deployment to try out a potential workaround for cloudflare issue: ``` Update - We are continuing to work on a fix for native CRC32 checksum handling in R2 APIs. If you run into an issue, please see the documentation for workarounds based on the SDK that you are using: https://developers.cloudflare.com/r2/examples/aws/ Jan 22, 2025 - 16:33 UTC Update - We are continuing to work on a fix for this issue. Jan 17, 2025 - 11:23 UTC Identified - AWS recently updated their SDKs to enable CRC32 checksums on multiple object operations by default. R2 does not currently support CRC32 checksums, and the default configurations will return header related errors such as Header 'x-amz-checksum-algorithm' with value 'CRC32' not implemented. Impacted users can either pin AWS SDKs to a prior version or modify the configuration to restore the prior default behavior of not checking checksums on upload. For more details, see the examples section of the R2 Docs for the relevant SDK: https://developers.cloudflare.com/r2/examples/aws/ Jan 17, 2025 - 03:20 UTC ``` --------- Co-authored-by: Conor <[email protected]>
danhalson
temporarily deployed
to
previews/1162/merge
GitHub Actions
Inactive
…ality_not_as_expected
danhalson
temporarily deployed
to
previews/1162/merge
GitHub Actions
Inactive
danhalson
deleted the
bugfix/843-Integration_Save_/_Login_functionality_not_as_expected
branch
Merged
danhalson
added a commit
that referenced
this pull request
Feb 6, 2025
## What's Changed * Support output tabs in pyodide by @loiswells97 in #1157 * Downloading the instructions by @loiswells97 in #1160 * Hack open function to write files in main thread by @loiswells97 in #1146 * Try pinning previous ubuntu version to avoid cloudflare issue by @danhalson in #1178 * Integration: Save / Login functionality not as expected by @create-issue-branch in #1162 * HTML audio video support by @loiswells97 in #1179 * Feat/editable instructions by @loiswells97 in #1166 * Add remove instructions button modal by @jamiebenstead in #1176 * fix dark mode colours by @conorriches in #1182 * Copy change: Project steps to Project instructions by @loiswells97 in #1183 * Fixing padding for first line of code block by @loiswells97 in #1184 * Fix contrast on dark mode instructions code block by @loiswells97 in #1187 * Markdown changes by @jamiebenstead in #1188 * Remove line from demoInstructions by @jamiebenstead in #1189 * Instructions syntax highlighting for CEfE by @loiswells97 in #1190 * Fixing instructions state when set to an empty string by @loiswells97 in #1191 * Identify caching issue for editor-ui by @create-issue-branch in #1186 ## New Contributors * @jamiebenstead made their first contribution in #1176 **Full Changelog**: v0.28.14...v0.29.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Login to save' button now automatically saves after logging in.
Closes #843