Improve the accuracy of downsampled texture colors #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that some error correction is applied by the fixed-function pipeline when operating on the downsampled (reduced-color) textures? Merely truncating the colors, as previously done, yields visible artifacts with an accumulating error consistent with the dropped precision (1 per 32 for bpp = 5). The base colors would have to be either uint8 or floats, which carry more information after all. The results are otherwise fairly exact, at least on the few maps I tested. This may also apply to lightmaps? (TBD)
rdw-software
force-pushed
the
downsampling-error-correction
branch
from
d84b025 to
0be1251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some error correction is applied by the fixed-function pipeline when operating on the downsampled (reduced-color) textures? Merely truncating the colors, as previously done, yields visible artifacts with an accumulating error consistent with the dropped precision (1 per 32 for bpp = 5). The base colors would have to be either uint8 or floats, which carry more information after all. The results are otherwise fairly exact, at least on the few maps I tested. This may also apply to lightmaps? (TBD)