Add CPU and memory usage to the performance metrics overlay #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code originally assumes time (in milliseconds), which doesn't allow for displaying RAM usage or other metrics. Since time is a sensible default, overriding the format for specific items seems generalized enough for now. A better approach might be to allow passing formatter functions and using tables instead of varargs (to be order-independent). But it's probably not needed, so defer until there's a reason to generalize further.
rdw-software
force-pushed
the
perf-metrics-upgrade
branch
from
942ce46 to
e8af18c
Compare
This isn't necessarily accurate due to multithreading concerns. While it serves to detect performance outliers, it's not indicative of the actual system load (by design).
rdw-software
force-pushed
the
perf-metrics-upgrade
branch
from
e8af18c to
5a692f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both are estimates and not expected to be 100% accurate due to various complexities like multithreading/C++ vs Lua etc.
The primary goal is to detect excessive resource usage and other "obvious" outliers, such as huge memory leaks or delays.