Enable generating blank textures using custom colors #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdw-software
force-pushed
the
conspicuous-fallback-textures
branch
from
503a548 to
5dca3e3
Compare
So far I've just silently assumed all textures are POT. Asserting is preferable though as it reduces the potential for nasty surprises.
Instead of a white texture that is easy to confuse with "something failed to load", let's pick a distinct color (like pink). As a first step, the generation logic must allow non-white colors - such as said pink "error" shade.
A runtime there could be validation errors, but they may be more difficult to debug than loud failures at the time to creation. Additionally, generating very large textures will always be costly, so exiting early helps to circumvent issues like stalling or memory exhaustion.
This is just so I don't forget the hex codes and have to look them up again.
rdw-software
force-pushed
the
conspicuous-fallback-textures
branch
from
d01b136 to
6ceb626
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a white texture that is easy to confuse with "something failed to load", let's pick a distinct color (like pink). As a first step, the generation logic must allow non-white colors - such as said pink "error" shade.