Merged PR 46881: Fix design issues

- Fix alignment of the left hand side
- Scrollbar of masterdetail and  loading... margins
- Fix the left side margin and updated documentation

Related work items: #1115099

README.md

@@ -1,4 +1,16 @@
-This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app).
+# Development
+How to setup your dev environment:
+
+  `cd ./azdo-extensions-compliancy-frontend/`
+
+  `npm i`
+
+  `npm start`
+
+Your favourite browser should pop-up! You can now view in the browser. 
+The index page doesn't contain anything. So go to: `/#releases ` . Some dummy data should pop up.
+
+You may need to configure Chrome to accept a [locally signed certificate](https://stackoverflow.com/questions/7580508/getting-chrome-to-accept-self-signed-localhost-certificate)
 
 ## Available Scripts
 
@@ -18,57 +30,21 @@ See the different [routes](src/index.tsx) for available reports.
 
 Runs the storybook to read stories of the available components. Makes it possible to checkout (and test) a component in isolation.
 
-### `npm test`
-
-Launches the test runner in the interactive watch mode.<br>
-See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.
-
-### `npm run build`
-
-Builds the app for production to the `build` folder.<br>
-It correctly bundles React in production mode and optimizes the build for the best performance.
-
-The build is minified and the filenames include the hashes.<br>
-Your app is ready to be deployed!
-
-See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.
-
-### `npm run eject`
-
-**Note: this is a one-way operation. Once you `eject`, you can’t go back!**
-
-If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.
-
-Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.
-
-You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.
-
-## Learn More
-
-You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started).
-
-To learn React, check out the [React documentation](https://reactjs.org/).
-
-### Code Splitting
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting
-
-### Analyzing the Bundle Size
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size
-
-### Making a Progressive Web App
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app
-
-### Advanced Configuration
-
-This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration
+## Develop in an Azure DevOps context
+Create a `.env.development.local` file in the root of the repository, with the following content:
+```
+REACT_APP_USE_AZDO_SERVICE=false
+REACT_APP_USE_AZDO_SDK=true
+REACT_APP_USE_COMPLIANCYCHECKER_SERVICE=false
+REACT_APP_USE_APP_INSIGHTS=false
+HTTPS=true 
 
-### Deployment
+```
+Be careful not to commit this file! (it's in `.gitignore`)
 
-This section has moved here: https://facebook.github.io/create-react-app/docs/deployment
+If you want to use real data (instead of dummy), change `REACT_APP_USE_AZDO_SERVICE=false` to `REACT_APP_USE_AZDO_SERVICE=true`.
 
-### `npm run build` fails to minify
+Go to https://dev.azure.com/raboweb-test, navigate to one of the projects. You will see a `Dev: ` version of the extension tabs. These will load content from your local running version.
 
-This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify
+# References
+- Azure DevOps Design system: https://azdevinternal.azureedge.net

src/BuildPipelines.tsx

@@ -185,9 +185,9 @@ export default class extends React.Component<IBuildPipelinesProps, IState> {
                         </div>
                     </ConditionalChildren>
 
-                    <div className="page-content page-content-top">
+                    <div className="page-content-top full-size">
                         {this.state.isLoading ? (
-                            <div>Loading...</div>
+                            <div className="page-content">Loading...</div>
                         ) : (
                             this.getTabContent()
                         )}

src/Builds.tsx

@@ -192,7 +192,7 @@ class Builds extends React.Component<
                     <div className="page-content page-content-top">
                         <Card>
                             {this.state.isLoading ? (
-                                <div>Loading...</div>
+                                <div className="page-content">Loading...</div>
                             ) : (
                                 <Table<ITableItem>
                                     columns={columns}

src/Overview.tsx

@@ -133,7 +133,7 @@ class Overview extends React.Component<IOverviewProps, IState> {
                     <div className="page-content page-content-top">
                         <Card>
                             {this.state.isLoading ? (
-                                <div>Loading...</div>
+                                <div className="page-content">Loading...</div>
                             ) : (
                                 <div>
                                     <Table<ITableItem>

src/ReleasePipelines.tsx

@@ -99,9 +99,9 @@ class ReleasePipelines extends React.Component<IReleasePipelinesProps, IState> {
 
                     <InfoBlock showMoreInfoText={true} />
 
-                    <div className="page-content page-content-top">
+                    <div className="page-content-top full-size">
                         {this.state.isLoading ? (
-                            <div>Loading...</div>
+                            <div className="page-content">Loading...</div>
                         ) : (
                             this.getTabContent()
                         )}

src/Releases.tsx

@@ -233,7 +233,7 @@ class Releases extends React.Component<
                     <div className="page-content page-content-top">
                         <Card>
                             {this.state.isLoading ? (
-                                <div>Loading...</div>
+                                <div className="page-content">Loading...</div>
                             ) : (
                                 <Table<ITableItem>
                                     columns={columns}

src/Repositories.tsx

@@ -95,9 +95,9 @@ class Repositories extends React.Component<IRepositoriesProps, IState> {
 
                     <InfoBlock showMoreInfoText={true} />
 
-                    <div className="page-content page-content-top">
+                    <div className="page-content-top full-size">
                         {this.state.isLoading ? (
-                            <div>Loading...</div>
+                            <div className="page-content">Loading...</div>
                         ) : (
                             <MasterDetail
                                 title="Repositories"

src/components/CompliancyHeader.tsx

@@ -59,7 +59,7 @@ class CompliancyHeader extends React.Component<ICompliancyHeaderProps, IState> {
     render() {
         return (
             <div>
-                <CustomHeader className="bolt-header-with-commandbar">
+                <CustomHeader className="bolt-header-with-commandbar margin-right-16">
                     <HeaderIcon
                         className="bolt-table-status-icon-large"
                         iconProps={{ iconName: "OpenSource" }}