Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[driver] fix function type and declaration for clk.c and clk.h #9954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

1078249029
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Accroding to #9950 , function and declaration should be fixed.

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@1078249029 1078249029 changed the title [driver] fix function type and return value for clk.c and clk.h [driver] fix function type and declaration for clk.c and clk.h Jan 27, 2025
@github-actions github-actions bot added the Doc This PR/issue related with documents label Jan 28, 2025
@Rbb666 Rbb666 removed the request for review from Cathy-lulu February 3, 2025 04:02
@unicornx unicornx self-requested a review February 3, 2025 12:40
Copy link
Contributor

@unicornx unicornx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你的这个 pr 的 分支上怎么有两个 commit,而且其中一个还是上次 #9950 的,请清理一下你的分支, 确保 rebase 到最新的 master 以及只保留你这个 pr 的修改内容,再重新提交。

另外建议你在 commit 中明确说明改动原因,不要再引用其他的 pr。

Fix useless return value of functions and declarations.Those functions always return RT_EOK, but caller check their error code either.

Signed-off-by: 1078249029 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants