Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaRocheSurYonEventsBridge: initial version #3704

Closed
wants to merge 1 commit into from

Conversation

marius851000
Copy link
Contributor

A site for a city where I live nearby.

I’m a bit unsure about 2 point:

  1. The dates. There is no "post-time", and the start time of some event is 1970, certainly a placeholder. Thus, post time may not represent the way it is sorted (it isn’t explicit which one is used, but it seems to be roughly chronological)
  2. Should I parse all pages, or only the first one? As of today, thay would make 5 pages to parse (including the first one). That seems reasonable, but I’m still a bit unsure that’s necessary. Will think a bit more about that, likely doing another PR if I actually implement that.

(also, thanks for this software. It was incredibly easy to write this despite my lack of experience with PHP)

@github-actions
Copy link

github-actions bot commented Sep 24, 2023

Pull request artifacts

Bridge Context Status
LaRocheSurYonEvents 1 untitled (pr) HTTP status 504 Gateway Time-out

last change: Monday 2023-10-16 06:13:42

@dvikan
Copy link
Contributor

dvikan commented Sep 24, 2023

since these are events you need to decide how you want to structure the feed.

one option is to include in the feed only those events which are happening the next 7 days.

@ORelio
Copy link
Contributor

ORelio commented Oct 13, 2023

  1. I'd suggest to provide event date as text inside $item['content'], not as item['timestamp'] because item timestamp is supposed to indicate when the entry is published on the website, not the event date itself. Since it's not stated on the site, better leave it empty.

  2. You already have 12 entries on first page, which looks more than enough to me. The software that reads your feed (aggregator/reader) will automatically keep old entries for you so you don't need to include all the pages in the feed.

@dvikan
Copy link
Contributor

dvikan commented Oct 13, 2023

agreed with @ORelio

should probably not populate the timestamp field at all here. Unless you can find the actual publication date of event announcement.

@dvikan dvikan closed this Oct 16, 2023
@dvikan
Copy link
Contributor

dvikan commented Oct 16, 2023

let know if u still here

@marius851000
Copy link
Contributor Author

marius851000 commented Oct 16, 2023 via email

@dvikan dvikan reopened this Oct 16, 2023
@dvikan
Copy link
Contributor

dvikan commented Jan 9, 2024

lemme know when u find time

@dvikan dvikan closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants