Remove the testing framework from the core #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the testing framework from the core. It is now hosted in a separate project, allowing for the reuse also in different repositories. Incidentally, with this organization, an old comment complaining with the unnecessary linking of rscore in all tests has been addresses. Signed-off-by: Alessandro Pellegrini <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #98 +/- ##
===========================================
- Coverage 87.29% 86.69% -0.60%
===========================================
Files 42 40 -2
Lines 1621 1458 -163
Branches 41 38 -3
===========================================
- Hits 1415 1264 -151
+ Misses 190 179 -11
+ Partials 16 15 -1
|
|
Documentation coverage is 80.6% 👍 |
4 tasks
Piccions
requested changes
May 10, 2023
This commit changes quotes to brackets in includes for headers that are referred to project files. Signed-off-by: Alessandro Pellegrini <[email protected]>
Piccions
reviewed
Jun 27, 2023
There was a problem hiding this comment.
I only left an additional comment regarding a leftover include inconsistency (we can afford to be picky here). Apart from that, thanks for the great PR @alessandropellegrini !
A leftover include was not corrected. Signed-off-by: Alessandro Pellegrini <[email protected]>
|
Thanks for reviewing all this again. I have addressed the last comment. |
|
Documentation coverage is 82.5% 👍 |
|
Documentation coverage is 82.5% 👍 |
Piccions
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the testing framework from the core. It is now hosted in a separate project, allowing for the reuse also in different repositories.
Incidentally, with this organization, an old comment complaining with the unnecessary linking of rscore in all tests has been addresses.