Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Make hipfft bazel rule publicly visible #99

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[ROCm] Make hipfft bazel rule publicly visible #99

merged 1 commit into from
Jan 22, 2025

Conversation

hsharsha
Copy link

No description provided.

@hsharsha hsharsha requested review from zahiqbal and Ruturaj4 January 22, 2025 23:01
Ruturaj4
Ruturaj4 approved these changes Jan 22, 2025
View reviewed changes
Copy link

@Ruturaj4 Ruturaj4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ruturaj4 Ruturaj4 merged commit bf63c46 into rocm-jaxlib-v0.5.0 Jan 22, 2025
6 of 9 checks passed
@Ruturaj4 Ruturaj4 deleted the r0.5.0-hipfft-public-visible branch January 22, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruturaj4 Ruturaj4 Ruturaj4 approved these changes

@zahiqbal zahiqbal Awaiting requested review from zahiqbal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsharsha @Ruturaj4