Obey CMAKE_BUILD_TYPE #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obey CMAKE_BUILD_TYPE when it is passed on the command line. Previous behavior remains: Debug by default ROCRTST_BLD_TYPE can set build type
benrichard-amd
requested review from
dayatsin-amd and
shwetagkhatri
as code owners
dayatsin-amd
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Thanks Ben. Looks good.
I think eventually we can remove the ROCRTST_BLD_TYPE altogether, but lets do it this way for now.
I will pull it from our internal repository:
https://github.com/AMD-ROCm-Internal/rocminfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
CMAKE_BUILD_TYPEon the commandline was having no effect as it was being overridden byROCRTST_BLD_TYPE.This change updates CMakeLists.txt so the build type can be passed via both
CMAKE_BUILD_TYPEandROCRTST_BLD_TYPEOriginal behavior remains intact:
-Debug build by default
-Build type can be set via
ROCRTST_BLD_TYPE