[CK_TILE] Add GetName for GEMM kernels #1791
Conversation
aledudek
requested review from
junliume,
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer,
bartekxk,
andriy-ca and
afagaj
as code owners
There was a problem hiding this comment.
I think it would be beneficial to make it much more comprehensive. Lets add also the size of warp tiles next to block tile. Additionally I'd add similar functions to Pipelines and block gemms, so that later on during benchmarking we could easily get report with what instance we're working on.
include/ck_tile/ops/gemm/pipeline/gemm_pipeline_ag_bg_cr_comp_v3.hpp
Outdated
Show resolved
Hide resolved
| std::ostringstream oss; | ||
| oss << s; | ||
| return oss.str(); |
There was a problem hiding this comment.
Wouldn't this print just integer value?
|
|
||
| inline std::string GemmPipelineSchedulerToString(const ck_tile::GemmPipelineScheduler& s) | ||
| { | ||
| std::ostringstream oss; |
There was a problem hiding this comment.
thread_local std::ostringstream oss ? then an object of this storage class is created when the thread of execution passes through its definition and is destroyed immediately when execution leaves the lexical.
| @@ -71,3 +72,10 @@ inline std::ostream& operator<<(std::ostream& os, const ck_tile::TailNumber& s) | |||
| } | |||
| return os; | |||
| } | |||
|
|
|||
| inline std::string GemmPipelineSchedulerToString(const ck_tile::GemmPipelineScheduler& s) | |||
| // clang-format off | ||
| using P_ = GemmPipeline; | ||
|
|
||
| auto prec_str = [&] () { |
There was a problem hiding this comment.
align? - here and others prec_str fn
|
|
||
| inline std::string GemmPipelineSchedulerToString(const ck_tile::GemmPipelineScheduler& s) | ||
| { | ||
| std::ostringstream oss; |
There was a problem hiding this comment.
oss.str("")? - it could be fine to clean buffer before
|
|
||
| return _SS_("gemm_problem_") + | ||
| _TS_(VectorLoadSize) + "x" + _TS_(kBlockSize) + "_" + | ||
| _TS_(kPadM) + "x" + _TS_(kPadN) + "x" + _TS_(kPadK) + "_" + |
There was a problem hiding this comment.
What do you think about the concat() function, to pass Scheduler and other params?
Proposed changes
Add GetName for GEMM kernels to easily print its name and a few other details.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
Small change. I am also open to print other kernel parameters.