v1.37 Fixing token error, enabling single-stream mode by default (#68)

ROCm · Nov 24, 2023 · 9e3a04c · 9e3a04c
1 parent 08997e8
commit 9e3a04c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,14 @@
 Documentation for TransferBench is available at
 [https://rocm.docs.amd.com/projects/TransferBench](https://rocm.docs.amd.com/projects/TransferBench).
 
+## v1.37
+
+### Changes
+* USE_SINGLE_STREAM is enabled by default now.  (Disable via USE_SINGLE_STREAM=0)
+
+### Fixes
+* Fix unrecognized token error when XCC_PREF_TABLE is unspecified
+
 ## v1.36
 
 ### Additions

diff --git a/src/include/EnvVars.hpp b/src/include/EnvVars.hpp
@@ -29,7 +29,7 @@ THE SOFTWARE.
 #include "Compatibility.hpp"
 #include "Kernels.hpp"
 
-#define TB_VERSION "1.36"
+#define TB_VERSION "1.37"
 
 extern char const MemTypeStr[];
 extern char const ExeTypeStr[];
@@ -190,7 +190,7 @@ class EnvVars
     useInteractive    = GetEnvVar("USE_INTERACTIVE"     , 0);
     usePcieIndexing   = GetEnvVar("USE_PCIE_INDEX"      , 0);
     usePrepSrcKernel  = GetEnvVar("USE_PREP_KERNEL"     , 0);
-    useSingleStream   = GetEnvVar("USE_SINGLE_STREAM"   , 0);
+    useSingleStream   = GetEnvVar("USE_SINGLE_STREAM"   , 1);
     useXccFilter      = GetEnvVar("USE_XCC_FILTER"      , 0);
     validateDirect    = GetEnvVar("VALIDATE_DIRECT"     , 0);
     enableDebug       = GetEnvVar("DEBUG"               , 0);
@@ -351,13 +351,15 @@ class EnvVars
     }
 
     // Parse preferred XCC table (if provided
+    prefXccTable.resize(numGpuDevices);
+    for (int i = 0; i < numGpuDevices; i++)
+    {
+      prefXccTable[i].resize(numGpuDevices, 0);
+    }
+
+    char* prefXccStr = getenv("XCC_PREF_TABLE");
+    if (prefXccStr)
     {
-      prefXccTable.resize(numGpuDevices);
-      for (int i = 0; i < numGpuDevices; i++)
-      {
-        prefXccTable[i].resize(numGpuDevices, 0);
-      }
-      char* prefXccStr = getenv("XCC_PREF_TABLE");
       char* token = strtok(prefXccStr, ",");
       int tokenCount = 0;
       while (token)
@@ -580,7 +582,7 @@ class EnvVars
     {
       printf("TransferBench v%s\n", TB_VERSION);
       printf("===============================================================\n");
-      if (!hideEnv) printf("[Common]             (Suppress by setting HIDE_ENV=1)\n");
+      if (!hideEnv) printf("[Common]                              (Suppress by setting HIDE_ENV=1)\n");
     }
     else if (!hideEnv)
       printf("EnvVar,Value,Description,(TransferBench v%s)\n", TB_VERSION);