Find non-default HIP SDK on Windows #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstefanuk
requested review from
babakpst,
yoichiyoshida,
bragadeesh and
AlexBrownAMD
as code owners
ellosel
reviewed
Jan 9, 2025
ellosel
reviewed
Jan 9, 2025
ellosel
reviewed
Jan 9, 2025
ellosel
reviewed
Jan 9, 2025
|
Is the end use case here to use with windows CI or within rocBLAS based build? |
|
Yes, partly, the builds for rocBLAS are intended to remain the same, using default install locations. This update is targeting improvements to toolchain management for the increasing number of one-off builds requested by Windows users. |
bstefanuk
force-pushed
the
windows-non-default-hip-sdk
branch
from
303c872 to
633bedf
Compare
ellosel
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When the HIP SDK isn't installed to the default location, then the current build strategy cannot find toolchain components without fully qualified paths, even though the environment variable HIP_PATH contains the relevant information. This PR updates the strategy that Tensile uses to find and verify toolchain components. Minor updates to how this process is conducted on Linux is included as needed. Also includes a document on troubleshooting the relevant error and adds formatting to Toolchain.py.