Do not use aliases as nested namespace specifiers #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellosel
requested review from
babakpst,
yoichiyoshida,
bragadeesh and
AlexBrownAMD
as code owners
TorreZuk
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
With clang 19, existing code is triggering warnings. The warning points out that one cannot use an alias template as a namespace specifier. See this reproducer: https://godbolt.org/z/xn6YhPKxv
Outcomes:
Warnings are no longer emitted.
Notable changes:
Used the name of the type directly rather than the alias.
Testing and Environment:
This only occurs in environments with clang 19. Tested by running the following command in Tensile:
and the following command from rocBLAS: