feat: gains isic_classification Revision 5
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobvjk
requested changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we update the dataset
isic_classificaitonto Revision 5, rather than deprecating it entirely.Since we are between releases, the
NEWS.mdwas adjusted appropriately, and I just removed all deprecation messages forisic_classificationentirely.@jacobvjk I would appreciate a review of the actual content of this PR, as I visually inspected the sectors to bridge them to PACTA sectors, there is a good chance I missed some.
Note, I did this entirely functionally, so it should be pretty easy to see the logic I used to map sectors.
Relates to #329