-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spi: Add new embedded-hal 1.0 interface #141
Conversation
The embedded-hal 1.0 interface requires the ability to do short sleeps.
8320451
to
95aeedf
Compare
Both open points are addressed; implementing SpiBus was a bit of a backwards exercise, but in the interest of keeping things easy to maintain and efficient for the case where it matters, I think it's a sensible choice to effectively route everything through an implementation that primarily caters for SpiDevice use cases. The test is more than a build test but less than a functional test (I don't even have the wires with me to loopback MISO and MOSI), but given that the one thing that went wrong earlier was misconfiguring the SPI device in a way that would indefinitely block any transaction, I think that's good enough. |
95aeedf
to
2ad598a
Compare
(ad review request: Yeah I know I have pending reviews myself on the UART side; got that branch open again already!) |
Co-authored-by: Teufelchen <[email protected]>
I think I have addressed all comments. In particular, you may want to have a look at fc0914f. |
Many kudos for reviewing this! That helped a lot both in making the API better and gaining confidence in riot-wrappers as a whole. |
SPI was the only peripheral that was stuck on embedded-hal 0.2 because there were major changes in the HAL, and because I had no test application.
So far, this is lacking: