Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/nrf5*: mark and resolve radio conflict #21250

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

mguetschow
Copy link
Contributor

Contribution description

RIOT does not support multiplexing the nrf radio between BLE and 802.15.4 modes. Currently, if nrfble was selected, netdev_default would still select nrf802154 and the feature conflict would not be noted.

Testing procedure

  1. USEMODULE="netdev_default nrfble" make -C examples/basic/hello-world BOARD=nrf52840dk all
  2. USEMODULE="nrf52840 nrfble" make -C examples/basic/hello-world BOARD=nrf52840dk all

On master both just report linker issues.

With this PR, 1 will build successfully without automatically selecting nrf802154 and 2 will report the feature conflict.

Issues/PRs references

Noticed while testing #20996

@mguetschow mguetschow requested a review from aabadie as a code owner February 27, 2025 13:33
@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: cpu Area: CPU/MCU ports labels Feb 27, 2025
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 27, 2025
@riot-ci
Copy link

riot-ci commented Feb 27, 2025

Murdock results

✔️ PASSED

7ef1f7e cpu/nrf52: do not select nrf52840 if nrfble is selected already

Success Failures Total Runtime
10271 0 10271 09m:41s

Artifacts

@dylad dylad added this pull request to the merge queue Feb 28, 2025
Merged via the queue into RIOT-OS:master with commit 526fc3c Feb 28, 2025
26 checks passed
@mguetschow mguetschow deleted the nrf-radio-conflict branch February 28, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants