{drivers/sx126x, ieee802154/submac, sys/net/ieee802154} run LoRa for sx126x over IEEE802.15.4 using submac #21202
+1,826
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian18
requested review from
leandrolanzieri,
aabadie,
MichelRottleuthner,
miri64,
PeterKietzmann and
benpicco
as code owners
github-actions
bot
added
Area: network
mguetschow
reviewed
Feb 10, 2025
| @@ -24,7 +24,7 @@ | |||
| #include "kernel_defines.h" | |||
| #include "errno.h" | |||
|
|
|||
| #define ENABLE_DEBUG 0 | |||
| #define ENABLE_DEBUG 1 | |||
There was a problem hiding this comment.
Suggested change
| #define ENABLE_DEBUG 1 | |
| #define ENABLE_DEBUG 0 |
This is how (well) it works at the moment. 1232 bytes to me seems to be a buffer limit. |
|
|
(see also https://ieeexplore.ieee.org/document/9580895 ;-)) |
benpicco
reviewed
Feb 17, 2025
| #endif | ||
| } | ||
| } | ||
| /* Do not compute IEEE 802.15.4 CRC because LoRa frame also provides CRC */ |
There was a problem hiding this comment.
but we still have to send it over the aether?
| gnrc_netreg_entry_t dump = GNRC_NETREG_ENTRY_INIT_PID(GNRC_NETREG_DEMUX_CTX_ALL, | ||
| gnrc_pktdump_pid); | ||
| _netreg_dump = dump; | ||
| gnrc_netreg_register(CONFIG_GNRC_PKTBUF_NETTYPE, &_netreg_dump); |
There was a problem hiding this comment.
Is it worth to be split out or is there a reason not to have this in gnrc_pkdump.c
There was a problem hiding this comment.
It's fine to keep it if it makes your life easier, but from the commit message alone I don't understand what it does and how it relates to this PR.
| } | ||
|
|
||
| LL_PREPEND(netreg[type], entry); |
|
This needs a rebase |
fabian18
force-pushed
the
mlpa/sx126x_ieee802154_lora
branch
from
3169eeb to
19c50ef
Compare
fabian18
force-pushed
the
mlpa/sx126x_ieee802154_lora
branch
from
6a7f19e to
ed79d3a
Compare
The issue with multiple pings is that the sender (IPV6) pushes to send the second ping request even before the last reply could be fully received. The receiver is sending parts of the first reply and the sender is sending parts of the second request and both dont get an ACK. [W]ait timeout and [i]nterval can be adjusted. I dont know if that has to work, or why it does not work. |
fabian18
force-pushed
the
mlpa/sx126x_ieee802154_lora
branch
from
feeba31 to
30e7657
Compare
Co-authored-by: ansocket <[email protected]> Co-authored-by: fabian18 <[email protected]>
fabian18
force-pushed
the
mlpa/sx126x_ieee802154_lora
branch
from
30e7657 to
85c8c3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Picked up #19172 to run IEEE802.15.4 over LoRa using the submac layer.
Testing procedure
Used to test with two
adafruit-metro-m4-expresshaving attached ashield_llcc68.Fragmented pings over 6lowpan was only working with increased timeouts.
Output of
gnrc_networkingwill be added.DEVELHELP=1 VERBOSE_ASSERT=1 USEMODULE+="shell_cmd_ps shield_llcc68 sx126x_ieee802154 bhp gnrc_txtsnd gnrc_pktdump" BOARD=adafruit-metro-m4-express make -C examples/gnrc_networking flash term PORT=/dev/ttyACM0Issues/PRs references
#19172 continued
#19668 is necessarily included