-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nanocoap_sock: implement observe (Client-Side) #21160
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good to me :)
I have been thinking for ages whether we should go for async sockets for nanocoap (both client and server), and provide the synchronous sock API on top of that.
IMO the synchronous interface is optimized for the rather synthetic "shell app use case". Any "headless" MCU would more likely want to use an async API and the ability to run server and client on the same endpoint.
But that is orthogonal to this PR.
8d0a4e9
to
dcded9d
Compare
5a58280
to
73f41af
Compare
Murdock results❌ FAILED 99a66d5 examples/nanocoap_server: add output if registration fails
Build failures (1)
Artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, some more comments inline and the CI also has comments.
73f41af
to
99a66d5
Compare
Contribution description
Testing procedure
A new
observe
command was added totests/net/nanocoap_cli
:Issues/PRs references
based on #21147