cpu/samd5x: disable ONDEMAND on clock with periph_can #21158
Closed
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From [SAME54 errata][1] 2.4.9: > ## On Demand > The CAN is not compatible with on-demand clock requests. > > ## Workaround > Clear the ONDEMAND bit to zero for the oscillator source that > provides the GCLK to the CAN. Since the same CAN peripheral is used across all supported SAMD5x MCUs, the same should be true for the other MCUs. [1]: https://ww1.microchip.com/downloads/aemDocuments/documents/MCU32/ProductDocuments/Errata/SAM-D5x-E5x-Family-Silicon-Errata-and-Data-Sheet-Clarification-DS80000748.pdf
github-actions
bot
added
Platform: ARM
benpicco
added
the
Type: bug
|
@maribu Any reasons to keep as draft ? |
|
No, we can drop this. In fact, the CAN not only can request the GCLK on demand, but also needs the APB clock for RAM access to actually be able to receive. So we need to The actual fix got upstream already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
From SAME54 errata 2.4.9:
Since the same CAN peripheral is used across all supported SAMD5x MCUs, the same should be true for the other MCUs.
Testing procedure
This should actually cause issue with the CAN driver, but it works fine for most boards.
For the board where CAN does not behave correctly, it does not fix the issue.
Issues/PRs references
None