Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-test.yml: also fetch host key from grenoble #21153

Merged
merged 2 commits into from
Jan 21, 2025
Merged

release-test.yml: also fetch host key from grenoble #21153

merged 2 commits into from
Jan 21, 2025
+6 −16

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 21, 2025 •
edited
Loading

@miri64 miri64 added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Jan 21, 2025
@miri64 miri64 requested a review from MrKevinWeiss January 21, 2025 13:18
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jan 21, 2025
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Jan 21, 2025
@miri64 miri64 changed the title Release tests/fix/grenoble host key release-test.yml: also fetch host key from grenoble Jan 21, 2025
@miri64
Copy link
Member Author

miri64 commented Jan 21, 2025

Testing procedure

Will start a release test on my fork.

https://github.com/miri64/RIOT/actions/runs/12887859755

MrKevinWeiss
MrKevinWeiss requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need at least strasbourg but why not just have all of them?

MrKevinWeiss
MrKevinWeiss approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw what you did, looks good!

@miri64 miri64 force-pushed the release-tests/fix/grenoble-host-key branch from e86bd33 to b87b62c Compare January 21, 2025 13:24
@miri64
Copy link
Member Author

miri64 commented Jan 21, 2025 •
edited
Loading

https://github.com/miri64/RIOT/actions/runs/12887946735/job/35931726186 works better now.

@riot-ci
Copy link

riot-ci commented Jan 21, 2025

Murdock results

✔️ PASSED

b87b62c release-test.yml: also fetch host key from grenoble

Success Failures Total Runtime
1 0 1 02m:10s

Artifacts

@MrKevinWeiss MrKevinWeiss added this pull request to the merge queue Jan 21, 2025
Merged via the queue into RIOT-OS:master with commit 297f7fe Jan 21, 2025
25 checks passed
@miri64 miri64 deleted the release-tests/fix/grenoble-host-key branch January 21, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @riot-ci @MrKevinWeiss