Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/drivers/candev: prefer periph_can when available #21145

Merged
merged 1 commit into from
Jan 21, 2025
Merged

tests/drivers/candev: prefer periph_can when available #21145

merged 1 commit into from
Jan 21, 2025

Conversation

maribu
Copy link
Member

@maribu maribu commented Jan 20, 2025

Contribution description

This changes the app config to prefer periph_can whenever that feature is provided, and fall back to mcp2515 as default if not.

Testing procedure

$ for board in same54-xpro native native64 samr21-xpro hifive1b; do printf "%s: " "$board"; make -C tests/drivers/candev BOARD=$board info-modules | grep 'periph_can\|mcp2515'; done
same54-xpro: periph_can
native: periph_can
native64: periph_can
samr21-xpro: mcp2515
hifive1b: mcp2515

Issues/PRs references

None

@maribu
tests/drivers/candev: prefer periph_can when available
e68d69f 
This changes the app config to prefer periph_can whenever that feature
is provided, and fall back to mcp2515 as default if not.
@maribu maribu added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tests Area: tests and testing framework Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 20, 2025
@maribu maribu requested review from vincent-d and benpicco January 20, 2025 18:07
@benpicco benpicco requested a review from kfessel January 20, 2025 19:18
@maribu maribu enabled auto-merge January 20, 2025 19:19
@riot-ci
Copy link

riot-ci commented Jan 20, 2025

Murdock results

✔️ PASSED

e68d69f tests/drivers/candev: prefer periph_can when available

Success Failures Total Runtime
18 0 18 01m:45s

Artifacts

@maribu maribu added this pull request to the merge queue Jan 20, 2025
Merged via the queue into RIOT-OS:master with commit e3cfff5 Jan 21, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@vincent-d vincent-d Awaiting requested review from vincent-d

@kfessel kfessel Awaiting requested review from kfessel

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maribu @riot-ci @benpicco