Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/nanopb: allow multiple proto locations #20543

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Apr 5, 2024

Contribution description

Our app has proto files in multiple locations, so allow to add them instead of overwriting them.

Testing procedure

tests/pkg/nanopb still works

Issues/PRs references

https://github.com/RIOT-OS/RIOT/pull/20400/files#r1553568720

@github-actions github-actions bot added the Area: pkg Area: External package ports label Apr 5, 2024
@benpicco benpicco added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 5, 2024
@benpicco benpicco requested a review from Teufelchen1 April 5, 2024 12:48
@riot-ci
Copy link

riot-ci commented Apr 5, 2024

Murdock results

✔️ PASSED

4b24be0 pkg/nanopb: allow multiple proto locations

Success Failures Total Runtime
10044 0 10045 10m:25s

Artifacts

@benpicco benpicco requested review from kfessel and kaspar030 April 5, 2024 13:06
@kfessel
Copy link
Contributor

kfessel commented Apr 5, 2024

we don't do that for other source files, eg if SRC is set we don add extra files;
local solution found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants