cpu/native: introduce periph_i2c_mock #20430
Open
+509
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Platform: native
This was referenced Feb 24, 2024
chrysn
reviewed
Feb 25, 2024
chrysn
added
Reviewed: 1-fundamentals
gdoffe
force-pushed
the
native_i2c_mock
branch
from
c94e3ff to
e5e81d1
Compare
gdoffe
force-pushed
the
native_i2c_mock
branch
from
865c036 to
f66aa4c
Compare
chrysn
reviewed
Feb 26, 2024
|
There's still a build error left, and I'd appreciated if the mocking part was somehow shown / tested. I've done both, but can't push directly to this branch, but you can pick the commits from cogip#1. |
chrysn
added
Reviewed: 3-testing
gdoffe
requested review from
leandrolanzieri,
aabadie and
MichelRottleuthner
as code owners
gdoffe
force-pushed
the
native_i2c_mock
branch
2 times, most recently
from
fc45e56 to
333dc02
Compare
Thx for patches @chrysn . Applied and tested: > i2c_write_bytes 0 10 0 0 1 0 1 2
i2c_write_bytes 0 10 0 0 1 0 1 2
Command: i2c_write_bytes(0, 0x0a, 0x00, [0x00, 0x01, 0x00, 0x01, 0x02])
Mock write intercepted; this write of 5 byte(s) is still ignored.
Success: i2c_0 wrote 5 bytes |
chrysn
approved these changes
Feb 28, 2024
done 🤞 |
|
Awesome, thanks! |
Fix:
bme680.c:42:39: error: use of GNU empty initializer extension
bme680_t *bme680_devs[BME680_NUMOF] = { };
^
Signed-off-by: Gilles DOFFE <[email protected]>
- <stdbool.h> is missing for bool type definition. - "container.h" is missing for ARRAY_SIZE macro definition. Signed-off-by: Gilles DOFFE <[email protected]>
Fix:
drivers/include/hm330x.h:66:12: error: missing binary operator before
token "("
Signed-off-by: Gilles DOFFE <[email protected]>
Fix: drivers/lsm6dsxx/include/lsm6dsxx_internal.h:148:47: error: binary constants are a C2X feature or GCC extension Signed-off-by: Gilles DOFFE <[email protected]>
Fix:
drivers/include/mtd_at24cxxx.h:49:1: error: initializer element is not
constant [-Werror=pedantic]
49 | (mtd_at24cxxx_t) { \
| ^
Signed-off-by: Gilles DOFFE <[email protected]>
Fix: error: format ‘%p’ expects argument of type ‘void *’ and: error: ISO C forbids empty initializer braces [-Werror=pedantic] Signed-off-by: Gilles DOFFE <[email protected]>
The pcf857x_gpio_write() is also returning void as pcf857x_gpio_*
functions.
This fixes following errors using native architecture:
RIOT/drivers/pcf857x/pcf857x.c:319:12: error: ISO C forbids ‘return’
with expression, in function returning void [-Werror=pedantic]
319 | return pcf857x_gpio_write(dev, pin, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Gilles DOFFE <[email protected]>
Fix: error: format ‘%p’ expects argument of type ‘void *’ Signed-off-by: Gilles DOFFE <[email protected]>
Fix: error: ISO C forbids empty initializer braces [-Werror=pedantic] and: error: ISO C requires a translation unit to contain at least one declaration [-Werror,-Wempty-translation-unit] Signed-off-by: Gilles DOFFE <[email protected]>
Fix: error: ISO C forbids empty initializer braces [-Werror=pedantic] Signed-off-by: Gilles DOFFE <[email protected]>
Signed-off-by: Gilles DOFFE <[email protected]>
Signed-off-by: Gilles DOFFE <[email protected]>
Fix: error: overflow in conversion from ‘int’ to ‘char’ changes value from ‘255’ to ‘-1’ [-Werror=overflow] Signed-off-by: Gilles DOFFE <[email protected]>
Signed-off-by: Gilles DOFFE <[email protected]>
Fix: error: ISO C forbids empty initializer braces [-Werror=pedantic] Signed-off-by: Gilles DOFFE <[email protected]>
Signed-off-by: Gilles DOFFE <[email protected]>
Signed-off-by: Gilles DOFFE <[email protected]>
Fix: error: binary constants are a C2X feature or GCC extension Signed-off-by: Gilles DOFFE <[email protected]>
Fix: error: ISO C forbids empty initializer braces [-Werror=pedantic] Signed-off-by: Gilles DOFFE <[email protected]>
Signed-off-by: Gilles DOFFE <[email protected]>
Give priority to RIOT_APPLICATION macro over __linux__ and __WIN32__ ones. Signed-off-by: Gilles DOFFE <[email protected]>
Signed-off-by: Gilles DOFFE <[email protected]>
size_t size is changing according to architecture. Fix diplay to 32 bits unsigned integer. Signed-off-by: Gilles DOFFE <[email protected]>
Fix:
drivers/sht2x/include/sht2x_params.h:134:50: error: missing binary
operator before token "("
Signed-off-by: Gilles DOFFE <[email protected]>
Signed-off-by: Gilles DOFFE <[email protected]>
This fixes following errors using native architecture: RIOT/drivers/pca9685/pca9685.c:42:15: error: format ‘%p’ expects argument of type ‘void *’, but argument 5 has type ‘const pca9685_params_t *’ [-Werror=format=] Signed-off-by: Gilles DOFFE <[email protected]>
Signed-off-by: Gilles DOFFE <[email protected]>
gdoffe
force-pushed
the
native_i2c_mock
branch
from
5345352 to
2720856
Compare
benpicco
reviewed
Feb 11, 2025
| \ No newline at end of file | ||
| +// *INDENT-ON* | ||
| + | ||
| -- |
There was a problem hiding this comment.
Why are you 'fixing' this? This just makes the package harder to maintain.
|
I'm surprised by all the churn. Try a rebase - we are no longer building |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This allows I2C emulation on native architecture in the same way than periph_gpio_mock.
All I2C function from this driver are set as weak to be easily overridden in each application.
Testing procedure